Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CNI dependencies to v1.0.1 #10

Closed
wants to merge 1 commit into from
Closed

Update CNI dependencies to v1.0.1 #10

wants to merge 1 commit into from

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Oct 23, 2021

Issue #, if available:
None

Description of changes:

  • Updates CNI plugins to v1.0.1

Release notes here: https://github.com/containernetworking/plugins/releases/tag/v1.0.1

  • This release fixes a breaking bug introduced in v1.0.0, where support for CNI version 0.4.0 or 1.0.0 was dropped by accident.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gaby
Copy link
Contributor Author

gaby commented Oct 23, 2021

@kzys This PR fixes a breaking bug introduced by #9 Thanks!

@kzys kzys self-requested a review October 23, 2021 15:51
@kzys
Copy link
Contributor

kzys commented Oct 23, 2021

Sorry. I forgot to ask about DCO (Signed-off: line). I'm going to add its check on GitHub Actions Monday.

@gaby
Copy link
Contributor Author

gaby commented Oct 23, 2021

@kzys Is that something I can add, to an extra commit? or would I need to submit everything with Signed-off ?

@kzys
Copy link
Contributor

kzys commented Oct 23, 2021

You just need to add Signed-off line on your commit with your name. Please see firecracker-containerd's README.md below.

https://github.com/firecracker-microvm/firecracker-containerd/blob/main/CONTRIBUTING.md#contributing-via-pull-requests

@gaby
Copy link
Contributor Author

gaby commented Oct 23, 2021

I'm going to create a new PR, cause Github is not friendly at all about amending commits.

@gaby gaby closed this Oct 23, 2021
@gaby gaby deleted the cni-update branch October 23, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants